openmsx: init at git-2017-11-02 #31184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukateras
reviewed
Nov 9, 2017
| stdenv.mkDerivation rec { | ||
|
|
||
| name = "openmsx-${version}"; | ||
| version = "git-2017-11-02"; |
There was a problem hiding this comment.
Why not 0.14.0? (https://github.com/openMSX/openMSX/releases/tag/RELEASE_0_14_0)
There was a problem hiding this comment.
I have talked with the openMSX developers in their IRC channel, and after presenting a bit of NixOS to them, they added a simple patch to make it build under Nix.
Do you think using the patch file is better than the hardcoded git?
There was a problem hiding this comment.
ping @yegortimoshenko
| OpenMSX is an emulator for the MSX home computer system. Its goal is | ||
| to emulate all aspects of the MSX with 100% accuracy. | ||
| ''; | ||
| homepage = http://openmsx.org; |
There was a problem hiding this comment.
Nitpick: HTTPS version is available too
| customBuildFile = ./custom-nixos.mk; | ||
|
|
||
| postUnpack = '' | ||
| cp ${customBuildFile} $sourceRoot/build/custom.mk |
There was a problem hiding this comment.
Semantically this fits better in postPatch, additionally making $sourceRoot unnecessary. Also customBuildFile can be inlined:
postPatch = ''
cp ${./custom-nixos.mk} build/custom.mk
'';
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
New package - openmsx
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)