Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages: Add version and pname attributes to packages #31176

Closed
wants to merge 1 commit into from
Closed

pythonPackages: Add version and pname attributes to packages #31176

wants to merge 1 commit into from

Conversation

adisbladis
Copy link
Member

Motivation for this change

Adding pname and version attributes to pythonPackages.

A few days ago I wanted to check how up to date things were in pythonPackages so I split out the version into a separate attribute to be more easily parsable.
After seeing #31173 I did the same for pname.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@adisbladis adisbladis force-pushed the pythonPackages-versionattr branch 4 times, most recently from 6d0ede5 to c545a0d Compare November 10, 2017 01:40
@adisbladis adisbladis closed this Nov 23, 2017
@FRidh
Copy link
Member

FRidh commented Nov 23, 2017 •
edited

...and I was just now rebasing this :)

@adisbladis
Copy link
Member Author

adisbladis commented Nov 23, 2017 •
edited

@FRidh I'm happy to reopen. :)
Just thought that three weeks and no feedback meant not much interest.

I have solved the conflicts and rebased the PR.

@adisbladis adisbladis reopened this Nov 23, 2017
@FRidh
Copy link
Member

FRidh commented Nov 23, 2017

Well, its quite a large PR and I don't have so much time anymore to spend on Nixpkgs.

I've cherry-picked all the non-python-packages.nix changes for now. Its building at https://hydra.nixos.org/eval/1413023.

@FRidh FRidh self-assigned this Nov 23, 2017
@FRidh
Copy link
Member

FRidh commented Nov 24, 2017

@adisbladis if you like to do regexes, you up for one removing name = ...; from python-modules?

@FRidh
Copy link
Member

FRidh commented Feb 11, 2018

Closing because the PR is by now outdated. I think we shouldn't bother with python-packages.nix as packages are being moved, and what is left in python-packages.nix is mostly unused packages.

@FRidh FRidh closed this Feb 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees

@FRidh FRidh

Labels
6.topic: python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@adisbladis @FRidh @vcunat @GrahamcOfBorg