Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to keep double quote of symbol in syntax higlight for crystal docs #5238

Conversation

makenowjust
Copy link
Contributor

crystal docs removes unneeded double of symbol. For example, there is src/hello.cr:

# ```
# :"hello"
# ```
module Hello
end

And crystal docs generates this against hello.cr:

2017-11-03 22 34 20

But my expectation is this (and it is this PR's output):

2017-11-03 22 33 33

I think it should keep user input even if this double quote is not needed.

Copy link
Member

@asterite asterite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@RX14 RX14 added this to the Next milestone Nov 3, 2017
@RX14 RX14 merged commit 3c7ed65 into crystal-lang:master Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants