Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snapraid: fix release checksum #31177

Merged
merged 1 commit into from Nov 5, 2017
Merged

snapraid: fix release checksum #31177

merged 1 commit into from Nov 5, 2017

Conversation

makefu
Copy link
Contributor

@makefu makefu commented Nov 3, 2017

Motivation for this change

it seams that the release tarball has changed again. However looking at the release page on github it does not show a change (last update may 2017). I have mirrored the current release tarball to archive.org for reference if the checksum should change again

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dezgeg
Copy link
Contributor

dezgeg commented Nov 3, 2017

By release tarball you mean https://github.com/amadvance/snapraid/releases/download/v11.1/snapraid-11.1.tar.gz ? Note that by using fetchFromGitHub you aren't downloading that but rather https://github.com/amadvance/snapraid/archive/v11.1.tar.gz + unpacking it.

@makefu
Copy link
Contributor Author

makefu commented Nov 3, 2017

Yes you are right, we are using the real source tarball, not the preprocessed and autogen'ed release.

However what i've actually meant is that the source tarball checksum changed and i do not really know why and what changed.

I've mirrored this to https://archive.org/download/nixos-stockholm-tarballs/7gnaq07fdn52hddpiip2czb640qrnrld-v11.1.tar.gz

@orivej
Copy link
Contributor

orivej commented Nov 3, 2017

Since we have pushed snapraid 11.1 on 2017-04-03 and their v11.1 tag contains commits from 2017-05-13, they have moved the tag. I think that we should add a comment that their tags can not be trusted (maybe with a link to this issue), and set rev = "commit hash".

@makefu
Copy link
Contributor Author

makefu commented Nov 3, 2017 •
edited

@orivej i will create an issue at the repo

EDIT: wupps, it seems they have disabled the issue tracker on github ... i will open a topic at the forum
EDIT2: https://sourceforge.net/p/snapraid/discussion/1677233/thread/4f376a6d/

@orivej orivej merged commit 68d4912 into NixOS:master Nov 5, 2017
@orivej
Copy link
Contributor

orivej commented Nov 5, 2017

Thanks, let's keep using the tag until this happens again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@makefu @dezgeg @orivej @GrahamcOfBorg