Fix nix-shell command example in python docs #31197
Conversation
The nix-shell command here is incorrect AFAICT. `-i` is supposed to specify the interpreter and `-p` specifies the packages.
| @@ -165,7 +165,7 @@ run the script in the `python3` shell. | |||
|
|
|||
| ```py | |||
| #! /usr/bin/env nix-shell | |||
| #! nix-shell -i 'python3.withPackages(ps: [ps.numpy])' | |||
| #! nix-shell -i python3 -p 'python3.withPackages(ps: [ps.numpy])' | |||
There was a problem hiding this comment.
python3.withPackages(ps: [ps.numpy]) is a bit different here from pythonPackages. It will return something like a wrapped python interpreter, that includes all python packages gives as argument.
But you are right, the example does seem to work here. Maybe ! nix-shell -i python3 -p python3Packages.numpy is better then.
There was a problem hiding this comment.
@Mic92 I think we shouldn't advertise anymore -p python3 -p python3.numpy because that works because of the shell hook which, in my opinion, is something for nix-shell development, and not for just creating an environment.
There was a problem hiding this comment.
well. but this approach does not work either:
$ cat ./test
#! /usr/bin/env nix-shell
#! nix-shell -i python3 -p 'python3.withPackages(ps: [ps.numpy])'
import numpy
$ ./test
error: syntax error, unexpected $undefined, at (string):1:94There was a problem hiding this comment.
Oops, indeed. The quotes are incorrect. Need to be "
The nix-shell command here is incorrect AFAICT.
-iis supposed to specify the interpreter and-pspecifies the packages.Fixes #31196
Motivation for this change
Incorrect example in documentation.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)