Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kafkacat: fix sandboxed build #31185

Merged
merged 1 commit into from Nov 3, 2017
Merged

kafkacat: fix sandboxed build #31185

merged 1 commit into from Nov 3, 2017

Conversation

pbogdan
Copy link
Member

@pbogdan pbogdan commented Nov 3, 2017

Motivation for this change

It won't build with sandboxing enabled.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@NeQuissimus
Copy link
Member

Thank you

@NeQuissimus NeQuissimus merged commit a5847e8 into NixOS:master Nov 3, 2017
@pbogdan
Copy link
Member Author

pbogdan commented Nov 3, 2017

Thanks!

@pbogdan pbogdan deleted the kafkacat-fix-build branch December 3, 2019 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pbogdan @NeQuissimus @GrahamcOfBorg