Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xfce4-settings: build w/ xorg-libinput, make some dependencies optional #31023

Merged
merged 2 commits into from Nov 16, 2017
Merged

xfce4-settings: build w/ xorg-libinput, make some dependencies optional #31023

merged 2 commits into from Nov 16, 2017

Conversation

lukateras
Copy link
Member

@lukateras lukateras commented Oct 31, 2017 •
edited

Motivation for this change

Closes #30148. After this change "Mouse and Touchpad" settings tab can be used to change libinput settings (scroll direction reversal, tap-to-click, scrolling mode all respond, I don't see much difference with higher acceleration values but if that's the case that'd be certainly an upstream issue).

This also makes optional packages nullable (as per TODO comment).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@lukateras
Copy link
Member Author

lukateras commented Nov 11, 2017 •
edited

/cc @edolstra

You are maintaining Xfce, so I think I need your approval to get this into the tree. Same with #31024.

@orivej orivej merged commit a131ab2 into NixOS:master Nov 16, 2017
@lukateras lukateras deleted the xfce4-settings/libinput branch December 18, 2017 05:38
@lukateras lukateras added the 6.topic: xfce The Xfce Desktop Environment label Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: xfce The Xfce Desktop Environment 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lukateras @orivej @GrahamcOfBorg