Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

languagetool: add command for HTTP server #31040

Merged
merged 1 commit into from Oct 31, 2017
Merged

Conversation

Zimmi48
Copy link
Member

@Zimmi48 Zimmi48 commented Oct 31, 2017

Motivation for this change

The LanguageTool extension for Firefox explains how to use it with your own local server: https://addons.mozilla.org/fr/firefox/addon/languagetool/

They recommend running an HTTP server. I have been unable to run an HTTP server using languagetool-server but following http://wiki.languagetool.org/http-server I was able to patch the derivation to add a languagetool-http-server command that accomplishes what I was aiming at.

Cc @edwtjo @jgeerds. You may know better ways to do this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@edwtjo edwtjo merged commit 6798212 into NixOS:master Oct 31, 2017
@edwtjo
Copy link
Member

edwtjo commented Oct 31, 2017

It's fine, thanks!

@Zimmi48 Zimmi48 deleted the languagetool branch November 2, 2017 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants