autofs: do not strip needed symbols #31038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orivej
added
the
9.needs: port to stable
|
@Ericson2314 ping |
|
@GrahamcOfBorg autofs |
|
@grahamc Somehow the attribute is Can I do this? @GrahamcOfBorg autofs5 |
|
@GrahamcOfBorg autofs5 |
GrahamcOfBorg
approved these changes
Nov 1, 2017
There was a problem hiding this comment.
For system: x86_64-linux
shrinking /nix/store/y19ha5f1i7sj6gsdhiq7lqn15pq40668-autofs-5.1.3/lib/autofs/mount_ext2.so
shrinking /nix/store/y19ha5f1i7sj6gsdhiq7lqn15pq40668-autofs-5.1.3/lib/autofs/lookup_nisplus.so
shrinking /nix/store/y19ha5f1i7sj6gsdhiq7lqn15pq40668-autofs-5.1.3/lib/autofs/mount_nfs.so
shrinking /nix/store/y19ha5f1i7sj6gsdhiq7lqn15pq40668-autofs-5.1.3/lib/autofs/mount_bind.so
gzipping man pages under /nix/store/y19ha5f1i7sj6gsdhiq7lqn15pq40668-autofs-5.1.3/share/man/
stripping (with flags -S) in /nix/store/y19ha5f1i7sj6gsdhiq7lqn15pq40668-autofs-5.1.3/lib /nix/store/y19ha5f1i7sj6gsdhiq7lqn15pq40668-autofs-5.1.3/sbin
patching script interpreter paths in /nix/store/y19ha5f1i7sj6gsdhiq7lqn15pq40668-autofs-5.1.3
checking for references to /tmp/nix-build-autofs-5.1.3.drv-0 in /nix/store/y19ha5f1i7sj6gsdhiq7lqn15pq40668-autofs-5.1.3...
moving /nix/store/y19ha5f1i7sj6gsdhiq7lqn15pq40668-autofs-5.1.3/sbin/* to /nix/store/y19ha5f1i7sj6gsdhiq7lqn15pq40668-autofs-5.1.3/bin
/nix/store/y19ha5f1i7sj6gsdhiq7lqn15pq40668-autofs-5.1.3
Closed
|
Thanks! Backported to 17.09: 4200dcd |
orivej
added
8.has: port to stable
|
Was the makefile just adding that flag? |
|
The Makefile contains this snippet: ifdef DONTSTRIP
STRIP ?= :
else
STRIP ?= strip --strip-debug
endifand then invokes something like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes #28282 after #27415. See #28282 (comment) and #28282 (comment) .
@Ericson2314 Is this fine or should we not unset STRIP here? Maybe export
STRIP="${STRIP:-strip} --strip-debug?Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)