Upstream changes without issue IDs:

 * User interface: various improvements for high resolution screens
 * User interface: added functionality to duplicate optical and floppy
                   images
 * User interface: various improvements for the virtual media manager
 * VMM: fixed emulation so that Plan 9 guests can start once more (5.1.0
        regression)
 * Storage: fixed regression breaking iSCSI
 * Audio: added HDA support for more exotic guests (e.g. Haiku)
 * Serial: fixed hanging I/O when using named pipes on Windows (5.2.0
           regression)
 * Serial: fixed broken communication with certain devices on Linux
           hosts
 * USB/OHCI: improved behavior so that the controller state after a VM
             reset is closer to the initial state after VM start
 * EFI: fixed HFS+ driver which in rare cases failed to access most
        files on a volume
 * Shared clipboard: fixed hang with OS X host and Linux guest
 * Linux hosts: fixed kernel module compilation and start failures with
                Linux kernel 4.14
 * X11 hosts: better handle WM_CLASS setting
 * Linux guests: fixed kernel module compilation and other problems with
                 Linux kernel 4.14
 * Linux guests: fixed various 5.2.0 regressions
 * Bridged networking: fixed duplicate EtherType in VLAN/priority tags
                       on Linux (5.2.0 regression)

The full changelog including issue IDs can be found at:

https://www.virtualbox.org/wiki/Changelog

Aside from just bumping the version number I also had to strip 3 levels
of the paths included in the guest-additions patches, because the
version was hardcoded in there and the patches still apply as-is.

I've re-added the stripped path using patchFlags and the -d option of
the patch utility.

Tested this by running all of the tests in the "virtualbox" NixOS VM
test module, here is the URL to the finished evaluation on my Hydra:

https://headcounter.org/hydra/eval/380191

Signed-off-by: aszlig <aszlig@nix.build>
Cc: @NeQuissimus, @orivej, @etu, @vcunat
Issue: #31640
Issue: #31037

This is done by adding two patches, one is the complete patch containing
the upstream fixes for version 5.2.2 backported against version 5.1.26.

The other one is basically the same patch, but only the relevant changes
for the guest additions and the hunks changed to use CR/LF instead of LF
line endings.

Both patches are based on [r62611], however the revision turned out to
not be the right one corresponding to the tarball, so instead of
rebasing the patch again I looked at the conflicts and the changes that
have been introduced in [r64183] was the reason for the conflict.

So I manually edited the second hunk for vbox_drv.c and dropped the
first three lines of context (those declaring the "i" variable). The
hunk still is distinct enough (not even another "vgacon_text_force" in
the source) so we shouldn't run into weird conflicts if we'd bump
VirtualBox to version 5.1.30.

While we could have fixed this by just updating VirtualBox to version
5.2.2, this would be a bit too intrusive (like @vcunat mentioned in
#31037 (comment)), not
only in our ecosystem but because version 5.2 has some known upstream
issues that are not resolved yet.

Quoting from https://www.virtualbox.org/wiki/Downloads:

   Note: (updated 8 December 2017) The Guest Additions image with the
   5.2.2 release still has some known problems with certain Linux
   distributions when 3D acceleration is enabled.

I have tested this change by running all the tests in the "virtualbox"
NixOS VM test against basically all of the kernel versions we ship
except linux-testing (4.15-rc1) and specialized versions. So the
specific linuxPackages_* attributes I've tested were:

  * linuxPackages_4_4 (failed, see below)
  * linuxPackages_4_9
  * linuxPackages_4_13
  * linuxPackages_4_14

Running the tests for Linux 4.4 have failed because the KVM guest
machines couldn't be started and timed out. However after running the
tests with the same kernel but the nixpkgs revision prior to this
commit, the tests had the same issue, so the test failure is unrelated
to this commit.

[r62611]: https://www.virtualbox.org/changeset/62611/vbox
[r64183]: https://www.virtualbox.org/changeset/64183/vbox

Signed-off-by: aszlig <aszlig@nix.build>
Cc: @svanderburg
Fixes: #32537