Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skypeforlinux: 5.4.0.1 -> 5.5.0.1 #31028

Merged
merged 1 commit into from Oct 31, 2017

Conversation

yrashk
Copy link
Contributor

@yrashk yrashk commented Oct 31, 2017

Motivation for this change

5.4.0.1 is no longer available (HTTP 404)

Things done
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

5.4.0.1 is no longer available (HTTP 404)
@disassembler
Copy link
Member

build works, runs fine, merging!

@disassembler disassembler merged commit 79cf1fc into NixOS:master Oct 31, 2017
@yrashk yrashk deleted the skypeforlinux-5.5.0.1 branch October 31, 2017 10:20
@orivej orivej mentioned this pull request Oct 31, 2017
@orivej orivej added the 8.has: port to stable A PR already has a backport to the stable release. label Oct 31, 2017
@orivej
Copy link
Contributor

orivej commented Oct 31, 2017

Released in 0dbd1b8 to address #31045 and #31047.

@CMCDragonkai
Copy link
Member

CMCDragonkai commented Nov 2, 2017

I thought that this is another example why we need to integrate content addressed upstream sources (my current work involving IPFS and Nix is part of this). But then I realised skype is a proprietary software. If there are restrictions to redistribution, does that mean it's not allowed to have skype source/binaries in IPFS and for Nixpkgs to use that as the upstream source?

@orivej
Copy link
Contributor

orivej commented Nov 2, 2017

That's so:

This license does not give you any right to, and you may not:
iv. publish, copy, rent, lease, sell, export, import, distribute, or lend the software or the Services, unless Microsoft expressly authorizes you to do so;

https://www.microsoft.com/en-us/servicesagreement/?intsrc=client-_-linux-_-1427%2F5.5.0.1%2F-_-menu.tou&setlang=en

Nixpkgs distinguish between unfree and unfreeRedistributable licenses, you can use that to cache the latter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: port to stable A PR already has a backport to the stable release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants