Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elm-oracle: init at 1.1.1 #31036

Closed
wants to merge 1 commit into from
Closed

elm-oracle: init at 1.1.1 #31036

wants to merge 1 commit into from

Conversation

ahstro
Copy link

@ahstro ahstro commented Oct 31, 2017 •
edited

Motivation for this change

I want elm-oracle.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

I followed the instructions here.

@periklis
Copy link
Contributor

@ahstro Be aware, that elm-oracle should be packaged under elmPackages and not nodePackages. I did the same mistake in #30320.

@ahstro
Copy link
Author

ahstro commented Oct 31, 2017

@periklis Hmm, that's unfortunate, I don't really know how to go about doing that, at least not in a clean way. What was the wall you struck with your PR?

Also, what is the purpose of the elmPackages namespace? From what I understand, nodePackages and haskellPackages are from npm and hackage respectively, where as elmPackages seem to specify the domain and not the source? I'm way to new to Nix/NixOS to know what the convention is.

@ahstro ahstro closed this Oct 31, 2017
@ahstro ahstro reopened this Oct 31, 2017
@periklis
Copy link
Contributor

@ahstro I would suggest to have a look on the two ruby-scripts in pkgs/development/compilers/elm/(elm2nix.rb|update-elm.rb). They are not supposed afaik as node2nix, but maybe you can contribute a small changeset.

@ahstro
Copy link
Author

ahstro commented Oct 31, 2017

Thanks! It would be cool to get a the opinion of a NixOS member before I dig into this though, so I don't spend a bunch of time for nothing :)

@globin
Copy link
Member

globin commented Oct 31, 2017

cc @domenkozar

@Mic92
Copy link
Member

Mic92 commented Nov 2, 2017

cc @svanderburg (not sure if you have an opinion on this).

@domenkozar
Copy link
Member

Well Elm infrastructure is not in best state. @ahstro I'm welcome to help you how to package Elm stuff, but there are some solutions out there.

Mic92 added a commit to Mic92/nixpkgs that referenced this pull request May 7, 2018
@Mic92
nodePackages.elm-oracle: init at 1.1.1
f343efc 
fixes NixOS#38353 NixOS#31036
@Mic92
Copy link
Member

Mic92 commented May 7, 2018

this is now part of nixpkgs.

@Mic92 Mic92 closed this May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: merge conflict 2.status: work-in-progress 6.topic: nodejs 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@ahstro @periklis @globin @Mic92 @domenkozar @matthewbauer @joachifm @Janik-Haag