Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clementine: Added gst-libav plugin #31033

Merged
merged 1 commit into from Nov 2, 2017
Merged

clementine: Added gst-libav plugin #31033

merged 1 commit into from Nov 2, 2017

Conversation

FPtje
Copy link
Contributor

@FPtje FPtje commented Oct 31, 2017 •
edited

Motivation for this change

Fixes regression introduced in 0322f66 that made clementine unable to play m4a files.

Pinging @jraygauthier for relevant previous commit.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

clementine: Added gst-libav plugin
16bfe58 
Fixes regression introduced in 0322f66 that made clementine unable
to play m4a files.
@disassembler
Copy link
Member

Maybe this fixes #30894?

@jraygauthier
Copy link
Member

So it would explain the missing gst-ffmpeg in gst 1 I mentionned in #27891 (comment). Nice find and sorry for the regression. The fix seems fine to me.

@Mic92 Mic92 merged commit 4d7c34f into NixOS:master Nov 2, 2017
@Mic92
Copy link
Member

Mic92 commented Nov 2, 2017

Does this needs to be backported?

@FPtje
Copy link
Contributor Author

FPtje commented Nov 2, 2017

Oh, yes please. Thanks!

@Mic92
Copy link
Member

Mic92 commented Nov 2, 2017

see: 4be2f03

@FPtje
Copy link
Contributor Author

FPtje commented Nov 2, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@FPtje @disassembler @jraygauthier @Mic92