Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.devpi_common: remove one test #31309

Merged
merged 1 commit into from Nov 6, 2017
Merged

Conversation

nlewo
Copy link
Member

@nlewo nlewo commented Nov 6, 2017

Motivation for this change

Fix hydra build

Things done

I've tryied to understand why this test is failing but I was not able to. This could be related to our version of requests since this test is parsing logs of this library (it seems it fails because i cannot get any logs).

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@nlewo nlewo requested a review from FRidh as a code owner November 6, 2017 09:40
@nlewo
Copy link
Member Author

nlewo commented Nov 6, 2017

I don't know if I had to push this PR since I don't propose a proper fix (I could not spent more time on this currently).

@FRidh FRidh merged commit 8048df4 into NixOS:master Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants