Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/tests/gitlab.nix: Unbreak config, still times out #31317

Merged
merged 1 commit into from Nov 6, 2017

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Nov 6, 2017

Motivation for this change

This partially fixes the Gitlab NixOS test. The module has had several required options added since the inception of this test, and they are now present. Gitlab also no longer serves on port 8080 on its own, but relies on a proxy-to-socket solution, which has also been added.

The test still times out even with extreme time limits on the gitlab service. The culprit is difficult to identify, but it should be possible to work on just that with this fix. I am able to run this on a libvirtd-deploy via nixops succesfully, so I am fairly confident that only the slowness in bundler/sidekiq needs to be addressed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@srhb srhb mentioned this pull request Nov 6, 2017
8 tasks
@globin globin merged commit 294bb6d into NixOS:master Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants