Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mono: init at 4.8 #31310

Merged
merged 1 commit into from Nov 17, 2017
Merged

mono: init at 4.8 #31310

merged 1 commit into from Nov 17, 2017

Conversation

kuznero
Copy link
Member

@kuznero kuznero commented Nov 6, 2017

Motivation for this change

Introduce mono-4.8 to nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

This is the replacement PR for #25230. Ping @copumpkin, @disassembler, @abbradar and @pSub.

@Mic92
Copy link
Member

Mic92 commented Nov 7, 2017

While testing all the binaries, I noticed:

$ ./soapsuds
Unhandled Exception:
System.Runtime.Serialization.SerializationException: Unable to find assembly 'soapsuds, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null'.

is that to be expected?

orivej
orivej approved these changes Nov 17, 2017
View reviewed changes
Copy link
Contributor

@orivej orivej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading #25230 it does not look like anyone wants to use mono 4.8 now. Nevertheless, it may be useful to merge this.

@abbradar
Copy link
Member

Let's merge, I'd like to continue my Mono work atop this (I'd lke to update to the latest versions as much packages in Nixpkgs as possible and 5.0 is indeed not as stable). I'll merge after it builds locally.

@abbradar abbradar merged commit fccc81a into NixOS:master Nov 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orivej orivej orivej approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kuznero @Mic92 @abbradar @orivej @GrahamcOfBorg