Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodejs: 8.8.0 -> 8.8.1 #30875

Merged
merged 1 commit into from Oct 28, 2017
Merged

nodejs: 8.8.0 -> 8.8.1 #30875

merged 1 commit into from Oct 28, 2017

Conversation

lo1tuma
Copy link
Member

@lo1tuma lo1tuma commented Oct 27, 2017

Motivation for this change

This fixes a regression introduced with nodejs 8.8.0.

Release Notes

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@adisbladis
Copy link
Member

Because the version that introduced the regression was a security fix release that was backported to 17.09 this also needs backporting to 17.09.

@globin globin merged commit e730815 into NixOS:master Oct 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lo1tuma @adisbladis @globin