Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sshlatex: init at 0.7 #30879

Merged
merged 1 commit into from Oct 28, 2017
Merged

sshlatex: init at 0.7 #30879

merged 1 commit into from Oct 28, 2017

Conversation

iblech
Copy link
Contributor

@iblech iblech commented Oct 27, 2017 •
edited

Motivation for this change

sshlatex is a tool which uploads LaTeX source files to a remote, runs LaTeX there, and streams the resulting PDF file to the local host. Because sshlatex prestarts LaTeX with the previous run's preamble, thereby preloading the required LaTeX packages, it is also useful in a purely local setting.

This pull request adds sshlatex to the Nix package database.

Things done

I'm a first-time contributor to NixOS and not yet familiar with the culture. Please don't refrain from criticizing this pull request! I'm happy to work on it so it meets the usual standards.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Oct 28, 2017

Could you add yourself as maintainer of this package.

@iblech iblech requested a review from edolstra as a code owner October 28, 2017 09:08
@iblech
Copy link
Contributor Author

iblech commented Oct 28, 2017

Thanks for your quick response, FRidh! I did so.

Also I force-pushed a change adding some runtime dependencies I had forgotten (bash, perl and gnutar).

@FRidh FRidh merged commit cf5ebcf into NixOS:master Oct 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iblech @FRidh @Janik-Haag