Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

systemd: remove udev attributes #30872

Merged
merged 1 commit into from Nov 4, 2017
Merged

systemd: remove udev attributes #30872

merged 1 commit into from Nov 4, 2017

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Oct 27, 2017

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@FRidh FRidh mentioned this pull request Oct 27, 2017
Closed
@FRidh FRidh requested a review from edolstra October 27, 2017 20:22
@vyp
Copy link
Member

vyp commented Oct 27, 2017 •
edited

Just curious, why? Edit: I see #30353 🙈 🙈

@FRidh FRidh merged commit decaeb3 into NixOS:master Nov 4, 2017
@vcunat
Copy link
Member

vcunat commented Nov 4, 2017

Fixed an eval error due to this. Travis shows it, but somehow people learned not to look at it. (Understandable due to the unreliability of our Travis setup.)

vcunat added a commit that referenced this pull request Nov 4, 2017
@vcunat
drbd: fix evaluation after #30872
bb87d2c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@FRidh @vyp @vcunat