libamqpcpp: init at 2.7.4 #32073
Merged
libamqpcpp: init at 2.7.4 #32073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRidh
reviewed
Nov 26, 2017
| { stdenv, fetchurl }: | ||
|
|
||
| stdenv.mkDerivation rec { | ||
| name = "libamqpcpp-2.7.4"; |
| stdenv.mkDerivation rec { | ||
| name = "libamqpcpp-2.7.4"; | ||
|
|
||
| src = fetchurl { |
There was a problem hiding this comment.
fetchFromGitHub may be preferable
There was a problem hiding this comment.
This looks much more suitable - thank you!
It appears to download the same file, but calculates a different hash for it; is this expected?
|
@GrahamcOfBorg build libamqpcpp |
There was a problem hiding this comment.
Failure for system: x86_64-darwin
make -C src all
make[1]: Entering directory '/private/tmp/nix-build-libamqpcpp-2.7.4.drv-0/AMQP-CPP-2.7.4/src'
g++ -Wall -c -I. -std=c++11 -MD -g -fpic -o deferredconsumer.o deferredconsumer.cpp
/nix/store/i6xy9nh39wwzs048hh6fabb2fbqphvya-bash-4.4-p12/bin/bash: g++: command not found
make[1]: *** [Makefile:52: deferredconsumer.o] Error 127
make[1]: Leaving directory '/private/tmp/nix-build-libamqpcpp-2.7.4.drv-0/AMQP-CPP-2.7.4/src'
make: *** [Makefile:9: all] Error 2
builder for '/nix/store/lr009h2fq2wz9i4b7ljg0flpq4x36jh6-libamqpcpp-2.7.4.drv' failed with exit code 2
error: build of '/nix/store/lr009h2fq2wz9i4b7ljg0flpq4x36jh6-libamqpcpp-2.7.4.drv' failed on ‘mac1’
error: build of ‘/nix/store/lr009h2fq2wz9i4b7ljg0flpq4x36jh6-libamqpcpp-2.7.4.drv’ failed
There was a problem hiding this comment.
Success for system: x86_64-linux
ln -r -s -f /nix/store/77zi1nmbsdm6zqvgnafy7mzy5ranmd7v-libamqpcpp-2.7.4/lib/libamqpcpp.so.2.7.4 /nix/store/77zi1nmbsdm6zqvgnafy7mzy5ranmd7v-libamqpcpp-2.7.4/lib/libamqpcpp.so.2.7
ln -r -s -f /nix/store/77zi1nmbsdm6zqvgnafy7mzy5ranmd7v-libamqpcpp-2.7.4/lib/libamqpcpp.so.2.7.4 /nix/store/77zi1nmbsdm6zqvgnafy7mzy5ranmd7v-libamqpcpp-2.7.4/lib/libamqpcpp.so
ln -r -s -f /nix/store/77zi1nmbsdm6zqvgnafy7mzy5ranmd7v-libamqpcpp-2.7.4/lib/libamqpcpp.a.2.7.4 /nix/store/77zi1nmbsdm6zqvgnafy7mzy5ranmd7v-libamqpcpp-2.7.4/lib/libamqpcpp.a
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/77zi1nmbsdm6zqvgnafy7mzy5ranmd7v-libamqpcpp-2.7.4
shrinking /nix/store/77zi1nmbsdm6zqvgnafy7mzy5ranmd7v-libamqpcpp-2.7.4/lib/libamqpcpp.so.2.7.4
stripping (with flags -S) in /nix/store/77zi1nmbsdm6zqvgnafy7mzy5ranmd7v-libamqpcpp-2.7.4/lib
patching script interpreter paths in /nix/store/77zi1nmbsdm6zqvgnafy7mzy5ranmd7v-libamqpcpp-2.7.4
checking for references to /tmp/nix-build-libamqpcpp-2.7.4.drv-0 in /nix/store/77zi1nmbsdm6zqvgnafy7mzy5ranmd7v-libamqpcpp-2.7.4...
/nix/store/77zi1nmbsdm6zqvgnafy7mzy5ranmd7v-libamqpcpp-2.7.4
MikePlayle
force-pushed
the
add-libamqpcpp
branch
from
f12cfe3
to
9e069f0
Compare
|
Should I try to fix the Darwin build failure? I've looked at the default.nix files for a few other C++ libraries, but none of them seem to include g++ as a dependency explicitly, as far as I can see. Being quite new to Nix I'm not entirely sure how to proceed. |
orivej
force-pushed
the
add-libamqpcpp
branch
from
9e069f0
to
3aecf95
Compare
|
Fixed compatibility with Darwin, moved to the proper place in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)