Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial TBS driver #32049

Merged
merged 1 commit into from Apr 22, 2018
Merged

initial TBS driver #32049

merged 1 commit into from Apr 22, 2018

Conversation

ck3d
Copy link
Contributor

@ck3d ck3d commented Nov 25, 2017

Motivation for this change

Add driver for TBS devices

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@matthewbauer
Copy link
Member

Looks good to me! Can you just drop 09fe07d to get rid of the conflict (you are already in maintainers it seems).

matthewbauer
matthewbauer requested changes Apr 21, 2018
View reviewed changes
Copy link
Member

@matthewbauer matthewbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Can you just drop 09fe07d to get rid of the conflict (you are already in maintainers it seems).

@ck3d
Copy link
Contributor Author

ck3d commented Apr 22, 2018

Thanks for reviewing. I updated PR.

@matthewbauer matthewbauer merged commit fb7cdbc into NixOS:master Apr 22, 2018
@matthewbauer matthewbauer mentioned this pull request Apr 22, 2018
Merged
@matthewbauer
Copy link
Member

Sorry too quick to do this. We are still getting an error:

https://hydra.nixos.org/build/73132864

@ck3d
Copy link
Contributor Author

ck3d commented Apr 23, 2018 •
edited

I updated to kernel-4.14. It now compiles with nixos-18.03.
Created now PR #39389

@matthewbauer
Copy link
Member

@GrahamcOfBorg build tbs

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: tbs

Partial log (click to expand)

Cannot nix-instantiate `tbs' because:
�[31;1merror:�[0m attribute 'tbs' in selection path 'tbs' not found

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: tbs

Partial log (click to expand)

Cannot nix-instantiate `tbs' because:
error: attribute 'tbs' in selection path 'tbs' not found

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: tbs

Partial log (click to expand)

Cannot nix-instantiate `tbs' because:
error: attribute 'tbs' in selection path 'tbs' not found

@cillianderoiste cillianderoiste mentioned this pull request Apr 27, 2018
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ck3d @matthewbauer @GrahamcOfBorg