statsd: restore support for {influx,librato,stackdriver} backends #32051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ma27
force-pushed
the
statsd/add-plugins
branch
from
d051622
to
18ce19c
Compare
|
I think it might be the best option to add a full-blown testcase for |
Ma27
changed the title
Ma27
changed the title
|
@garbas I added a simple testcase and removed the WIP label. If everything is fine for you, we can merge this now :-) |
Ma27
force-pushed
the
statsd/add-plugins
branch
2 times, most recently
from
e4452e0
to
d582406
Compare
|
@GrahamcOfBorg test statsd |
|
If your test is not in |
|
ah good to know :-) |
Ma27
force-pushed
the
statsd/add-plugins
branch
from
d582406
to
d7157a1
Compare
|
@GrahamcOfBorg test statsd |
There was a problem hiding this comment.
Failure for system: x86_64-linux
error: anonymous function at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/nixos/tests/statsd.nix:1:25 called with unexpected argument ‘system’, at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/nixos/tests/make-test.nix:5:41
|
@Mic92 how does the bot call these tests? (it's actually the first test I contribute to nixpkgs and I just used |
These packages will be placed into an environment using
`backendsToPackages`. This function explicitly maps backends to
`pkgs.nodePackages.${type}` unless it's a builtin. This ensures that only
valid backends that work on NixOS are used (if not, the build already
breaks at evaluation time).
The log will be redirected to `stdout` to be able to watch the entire
output using `journalctl`.
Configuration parameters for the backends need to be set using
`services.statsd.extraConfig` as each backend has its own options and
all of them shouldn't be validated and checked explicitly and manually.
Ma27
force-pushed
the
statsd/add-plugins
branch
from
d7157a1
to
3dff2ce
Compare
|
@garbas I just resolved the merge conflict introduced by the autogenerated node2nix expressions, so this should be mergable again :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
adds backends (follow-up for #31235)
These packages will be placed into an environment using
backendsToPackages. This function explicitly maps backends topkgs.nodePackages.${type}unless it's a builtin (some backendsare directly available in the
statsdsource tree). This ensures that onlyvalid backends that work on NixOS are used (if not, the build already
breaks at evaluation time).
The log will be redirected to
stdoutto be able to watch the entireoutput using
journalctl.Configuration parameters for the backends need to be set using
services.statsd.extraConfigas each backend has its own options andall of them shouldn't be validated and checked explicitly and manually.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)