Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtk-doc: clean up XML_CATALOG_FILES patch #32037

Merged
merged 1 commit into from Nov 27, 2017

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Nov 25, 2017

Motivation for this change

libxml2 1.9.7 supports the XML_CATALOG_FILES environment variable natively by using empty catalogfile argument.

The change does not have any effect on the package – directory trees are identical, up to self-referring hashes. Apparently, the various packages have a copy of the m4 files in their source trees so we will need to patch them too when we want to enable building docs for them.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

libxml2 1.9.7 supports the XML_CATALOG_FILES environment variable
natively by using empty catalogfile argument.
@vcunat vcunat merged commit 0124cbd into NixOS:staging Nov 27, 2017
@jtojnar jtojnar deleted the gtk-doc-cleanup branch November 27, 2017 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants