Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flink: init at 1.3.2 #32036

Merged
merged 2 commits into from Dec 9, 2017
Merged

flink: init at 1.3.2 #32036

merged 2 commits into from Dec 9, 2017

Conversation

mbode
Copy link
Contributor

@mbode mbode commented Nov 25, 2017 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@orivej
Copy link
Contributor

orivej commented Nov 29, 2017

Please review my changes.

@mbode
Copy link
Contributor Author

mbode commented Dec 9, 2017

Looks good as far as I can tell.

@orivej orivej merged commit c7bf1b8 into NixOS:master Dec 9, 2017
@mbode mbode deleted the flink-1_3_2 branch December 9, 2017 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mbode @orivej @GrahamcOfBorg