Adding myself #32076
Closed
Adding myself #32076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added myself
adisbladis
requested changes
Nov 26, 2017
| @@ -279,6 +279,7 @@ | |||
| hodapp = "Chris Hodapp <hodapp87@gmail.com>"; | |||
| hrdinka = "Christoph Hrdinka <c.nix@hrdinka.at>"; | |||
| htr = "Hugo Tavares Reis <hugo@linux.com>"; | |||
| hyper_ch = "Stephan Jau <nixos@sjau.ch>"; | |||
There was a problem hiding this comment.
I know hyper_ch is your irc handle but this should be your github username so its easier to ping you
There was a problem hiding this comment.
This will not matter with the merge of #31739.
|
I think this maybe belongs in your other PR #32053 It should be amended and rebased so adding yourself to the maintainers list comes first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added myself
Motivation for this change
Eval is failing because I'm on the maintainers list
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)