nginxModules.rtmp: v1.1.11 -> v1.2.0 & add support for gcc-7 #32038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds support for gcc-7 and fixes nginx for NixOS#31747
andir
force-pushed
the
nginx-rtmp-gcc7
branch
from
0ed2336
to
a004f9f
Compare
|
CC maintainers @thoughtpolice @raskin @fpletz |
|
hello just installed ubuntu 20.04 that apparently comes with gcc9 and I m stuck with the same issue. /root/nginx-rtmp-module-master/ngx_rtmp_eval.c:160:17: error: this statement may fall through [-Werror=implicit-fallthrough=] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The RTMP module requires a few
/* fall through */comments with gcc-7which are included in the introduced patch. The used patch was proposed
to the upstream repo [1] quite a while ago so it probably is best to
include it for now.
[1] arut/nginx-rtmp-module#1125
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)