Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lirc: 0.9.4 -> 0.10.0 + more driver #32042

Merged
merged 4 commits into from Jan 31, 2018
Merged

lirc: 0.9.4 -> 0.10.0 + more driver #32042

merged 4 commits into from Jan 31, 2018

Conversation

ck3d
Copy link
Contributor

@ck3d ck3d commented Nov 25, 2017

  • added a bunch of optional libraries to get more IR drivers built
  • removed deprecated configure flags
  • unneeded make flags
  • simplified install flags
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@ck3d
lirc: 0.9.4 -> 0.9.4d + more driver
47b9934 
* added a bunch of optional libraries to get more IR drivers built
* removed deprecated configure flags
* unneeded make flags
* simplified install flags
@ck3d ck3d mentioned this pull request Nov 29, 2017
Merged
8 tasks
@peterhoeg
Copy link
Member

Looks good but cc @FRidh as our resident python guru.

FRidh
FRidh reviewed Dec 7, 2017
View reviewed changes
pkgs/development/libraries/lirc/default.nix Outdated

nativeBuildInputs = [ pkgconfig help2man ];

buildInputs = [ alsaLib xlibsWrapper python3 libxslt ];
buildInputs = [ alsaLib xlibsWrapper libxslt systemd libusb libftdi1 ]
++ (with python3Packages; [ python pyyaml ]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could have used with python3.pkgs;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reporting, i updated my PR

@ck3d ck3d changed the title lirc: 0.9.4 -> 0.9.4d + more driver lirc: 0.9.4 -> 0.10.0 + more driver Dec 9, 2017
@ck3d
Copy link
Contributor Author

ck3d commented Dec 9, 2017

Updated to 0.10.0 which release a few days ago.

@peterhoeg peterhoeg merged commit 5097e84 into NixOS:master Jan 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ck3d @peterhoeg @FRidh @GrahamcOfBorg