Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 49a5791bc4f2
Could not load branches
Nothing to show
Could not load tags
Nothing to show
{{ refName }}
default
...
head repository: NixOS/nixpkgs
compare: 728446f75568
Could not load branches
Nothing to show
Could not load tags
Nothing to show
{{ refName }}
default
- 9 commits
- 32 files changed
- 2 contributors
Commits on Nov 13, 2017
-
Configuration menu - View commit details
-
Copy full SHA for c0a04ec - Browse repository at this point
Copy the full SHA c0a04ecView commit details -
bfd, opcodes: Init separate derivations for binutils libraries
On most distros, these are just built and distributed as part of binutils. We don't use binutils across the board, however, but rather switch between binutils and a cctools-binutils mashup, and change the outputs on binutils too. This creates a combinatorial conditional soup which is hard to maintain. My hope is to lower the the state space. While my patch isn't the most maintainable, they make downstream packages become more maintainable to compensate. The additional derivations themselves are completely platform-agnostic, always they always supports all possible target platforms, and always yield "out" and "dev" outputs. That, in turn, allows downstream packages to not worry about a dependency shape-shifting under them. In fact, the actual binutils package can avoid needing multiple outputs now that these serve the requisite libraries, so that also can become simpler on all platforms, too, removing the original wart this PR circumnavigates for now. Actually changing the binutils package to leverage is a mass rebuild, however, so I'll leave that for a separate PR. I do hope to upstream something like my patch too, but until then I'll make myself maintainer of these derivations
1Configuration menu - View commit details
-
Copy full SHA for de28bd4 - Browse repository at this point
Copy the full SHA de28bd4View commit details -
- Use nativeBuildInputs - Use libraries opcodes and bfd, rather than all of binutils
Configuration menu - View commit details
-
Copy full SHA for f72bffb - Browse repository at this point
Copy the full SHA f72bffbView commit details -
treewide: Try to avoid depending on binutils directly
One should depend on - `stdenv.cc.bintools`: for executables at build time - `libbfd` or `libiberty`: for those libraries - `targetPackages.cc.bintools`: for exectuables at *run* time - `binutils`: only for specifically GNU Binutils's executables, regardless of the host platform, at run time.
2Configuration menu - View commit details
-
Copy full SHA for d7bddc2 - Browse repository at this point
Copy the full SHA d7bddc2View commit details -
Configuration menu - View commit details
-
Copy full SHA for e65259f - Browse repository at this point
Copy the full SHA e65259fView commit details -
binutils, gdb: Do not expose libbfd or libopcodes, and be multitarget
There are separate derivations for these libraries and we don't want conflict. Multitarget is generally more useful, and will eventually speed up cross builds, so why not?!
Configuration menu - View commit details
-
Copy full SHA for f8741c3 - Browse repository at this point
Copy the full SHA f8741c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for ff023c9 - Browse repository at this point
Copy the full SHA ff023c9View commit details
Commits on Nov 14, 2017
-
Configuration menu - View commit details
-
Copy full SHA for eaacf47 - Browse repository at this point
Copy the full SHA eaacf47View commit details -
Merge pull request #30484 from obsidiansystems/libbfd
bfd, opcodes: Init separate derivations for binutils libraries
Configuration menu - View commit details
-
Copy full SHA for 728446f - Browse repository at this point
Copy the full SHA 728446fView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 49a5791bc4f2...728446f75568