Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos.tests.keymap.*: increase timeouts #32020

Closed
wants to merge 1 commit into from

Conversation

vcunat
Copy link
Member

@vcunat vcunat commented Nov 25, 2017

I'm not sure why, but the keymap test have been timing out relatively often on Hydra lately, requiring manual restarts. Perhaps some builders tend to get overloaded.

@aszlig: any ideas?

I'm not sure why, but the keymap test have been timing out relatively
often on Hydra lately, requiring manual restarts.
Perhaps some builders tend to get overloaded.
@aszlig
Copy link
Member

aszlig commented Nov 25, 2017

@vcunat: Do you have a build log of such a timeout?

@aszlig
Copy link
Member

aszlig commented Nov 25, 2017

Found one, but I'm not quite sure whether increasing the timeout to 100 seconds would help here.

At least when looking at the kernel time stamps, it doesn't look like it's a problem with build machine load.

@vcunat
Copy link
Member Author

vcunat commented Nov 25, 2017

@aszlig: I restarted a couple that succeeded at the second go on Hydra, but azerty just won't: https://hydra.nixos.org/build/64738895#tabs-buildsteps

@vcunat
Copy link
Member Author

vcunat commented Nov 25, 2017

Oh, I thought it was timing out, but the it's just printing source code of that message and not actually getting to the timeout.

@vcunat
Copy link
Member Author

vcunat commented Nov 25, 2017

Hmm, the exit code 1 would in the end suggest a timeout to me, but the log isn't very "readable" to me.

@grahamc
Copy link
Member

grahamc commented Nov 25, 2017

@GrahamcOfBorg test keymap.azerty

@vcunat
Copy link
Member Author

vcunat commented Nov 25, 2017

I had tested it locally (on x86_64-linux), but I can't well reproduce the problem and thus measure whether it's likely to make a difference...

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-linux

cannot build derivation ‘/nix/store/f0bvvn7hrrkxvsqb1kzq4jpqhzf9v8w1-etc.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/mib6ppwhq6k7nbmmkidqkd9n349x71jx-stage-1-init.sh.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/70varmwpcpc9ylkcrzyjhc9yz9sci743-initrd.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/c74w4qhpbidn7q8ay4lhwaw8kvsjy4dj-nixos-system-machine-18.03.git.17e66aa.drv’: 6 dependencies couldn't be built
cannot build derivation ‘/nix/store/l45lllbvwg1n2nhwx0x058m71g33cnf6-closure-info.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/c97gh72siclhkp3i2v5fwiqsnkppf8hj-run-nixos-vm.drv’: 2 dependencies couldn't be built
cannot build derivation ‘/nix/store/asav3qi2qjjnh4b724dpm20hl9wx7nyj-nixos-vm.drv’: 2 dependencies couldn't be built
cannot build derivation ‘/nix/store/ssm0b0ww1y6q2bgyhaph39pv0kd6iz2l-nixos-test-driver-keymap-azerty.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/3bsglhf1jsj30bls2yn4msd75hbxrbhg-vm-test-run-keymap-azerty.drv’: 1 dependencies couldn't be built
error: build of ‘/nix/store/3bsglhf1jsj30bls2yn4msd75hbxrbhg-vm-test-run-keymap-azerty.drv’ failed

@vcunat
Copy link
Member Author

vcunat commented Nov 25, 2017

^^ that would be the mass rebuild on master, I guess.

@pbogdan
Copy link
Member

pbogdan commented Nov 25, 2017

Based on debugging code @aszlig wrote in aszlig@596bdaa:

failure

Looks like perhaps wrong xterm window is in focus? Based on the hash bhrwaz91305gwa.. window is the one running the test-input-reader script (I may be misunderstanding how the test is supposed to work).

@aszlig
Copy link
Member

aszlig commented Nov 26, 2017

Yep, if you look at the a in the front window this clearly is wrong, fixing...

@aszlig
Copy link
Member

aszlig commented Nov 26, 2017

Sorry, fell asleep, but the real issue is 410f0f0 I think (because IMHO needing to set xterm.enable to false and the default desktopManager really shouldn't be necessary), because the tests set desktopManager.default to none but this commit causes it to use xterm despite of this, which is why we get an additional xterm window.

vcunat referenced this pull request Dec 25, 2017
I had the basic version of this laying around for some while but didn't
continue on it. Originally it was for testing support for the Neo layout
introduced back then (8cd6d53).

We only test the first three Neo layers, because the last three layers
are largely comprised of special characters and in addition to that the
support for the VT keymap seems to be limited compared to the Xorg
keymap.

Yesterday @NicolasPetton on IRC had troubles with the Colemak layout
(IRC logs: http://nixos.org/irc/logs/log.20160330, starting at 16:08)
and I found that test again, so I went for improving and adding to
<nixpkgs>.

While the original problem seemed to be related to GDM, we can still add
another subtest that checks whether GDM correctly applies the keyboard
layout. However I don't have a clue how to properly configure the
keyboard layout on GDM, at least not within the NixOS configuration.

The main goal of this test is not to test a complete set of all key
mappings but to check whether the keymap is loaded and working at all.

It also serves as an example for NixOS keyboard configurations.

The list of keyboard layouts is by no means complete, so everybody is
free to add their own to the test or improve the existing ones.

Signed-off-by: aszlig <aszlig@redmoonstudios.org>
@samueldr
Copy link
Member

I'm guessing #39400 made this irrelevant, right @vcunat?

@vcunat
Copy link
Member Author

vcunat commented Aug 26, 2018

Oh, yes, I think so. I forgot this PR. The issue turned out to be rather complicated.

@vcunat vcunat closed this Aug 26, 2018
@vcunat vcunat deleted the p/keymap-reliability branch August 26, 2018 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants