Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minijail: init at android-8.0.0_r34 #32010

Merged
merged 1 commit into from Nov 25, 2017
Merged

minijail: init at android-8.0.0_r34 #32010

merged 1 commit into from Nov 25, 2017

Conversation

pcarrier
Copy link
Contributor

@pcarrier pcarrier commented Nov 24, 2017

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@lheckemann
Copy link
Member

Missing an entry in pkgs/top-level/all-packages.nix! :)

@lheckemann
Copy link
Member

@GrahamcOfBorg build minijail

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

error: assertion failed at /tmp/nix-ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/32010/pkgs/tools/system/minijail/default.nix:3:1

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

error: assertion failed at /tmp/nix-ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/32010/pkgs/tools/system/minijail/default.nix:3:1

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

'libminijail.h' -> '/nix/store/lw2g91jc6jyymssn1qv97i8wc17nx4qx-minijail-android-8.0.0_r34/include/libminijail.h'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/lw2g91jc6jyymssn1qv97i8wc17nx4qx-minijail-android-8.0.0_r34
shrinking /nix/store/lw2g91jc6jyymssn1qv97i8wc17nx4qx-minijail-android-8.0.0_r34/bin/minijail0
shrinking /nix/store/lw2g91jc6jyymssn1qv97i8wc17nx4qx-minijail-android-8.0.0_r34/lib/libminijailpreload.so
shrinking /nix/store/lw2g91jc6jyymssn1qv97i8wc17nx4qx-minijail-android-8.0.0_r34/lib/libminijail.so
stripping (with flags -S) in /nix/store/lw2g91jc6jyymssn1qv97i8wc17nx4qx-minijail-android-8.0.0_r34/lib  /nix/store/lw2g91jc6jyymssn1qv97i8wc17nx4qx-minijail-android-8.0.0_r34/bin 
patching script interpreter paths in /nix/store/lw2g91jc6jyymssn1qv97i8wc17nx4qx-minijail-android-8.0.0_r34
checking for references to /tmp/nix-build-minijail-android-8.0.0_r34.drv-0 in /nix/store/lw2g91jc6jyymssn1qv97i8wc17nx4qx-minijail-android-8.0.0_r34...
/nix/store/lw2g91jc6jyymssn1qv97i8wc17nx4qx-minijail-android-8.0.0_r34

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

/nix/store/lw2g91jc6jyymssn1qv97i8wc17nx4qx-minijail-android-8.0.0_r34

Copy link
Member

@lheckemann lheckemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensibly done, thanks for the package!

@@ -0,0 +1,42 @@
{ stdenv, fetchgit, libcap }:

assert stdenv.isLinux;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete this line.

description = "Sandboxing library and application using Linux namespaces and capabilities";
license = stdenv.lib.licenses.bsd3;
maintainers = with stdenv.lib.maintainers; [pcarrier];
platforms = stdenv.lib.platforms.linux;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The assert above is handled by here.

@Mic92 Mic92 merged commit b0bf60a into NixOS:master Nov 25, 2017
@pcarrier pcarrier deleted the pcarrier/minijail branch November 25, 2017 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants