[WIP] Fix nixpkgs evaluate #32019
Closed
[WIP] Fix nixpkgs evaluate #32019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm sympathetic to the idea that perhaps we are overusing exceptions, but these fixes are rather verbose and ungainly. I read a bit of the thread this came from, but will need to dive into it further to see what the objective is. |
|
I'm closing this as it bitrots. I may resume the work if there will be anyone else who'd like to use Nixpkgs as knowledge database |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
#31884
I wanted to do a query on all packages to get some derivation attributes but found that some attribute values in
all-packages.nixdon't evaluate.Also, this fixes some obscure bugs with
.override, see #11226 (comment)Things done
This is an attempt to fix evaluation, but it is more like proof-of-concept and not really mergeable.
Especially the removed cross-compilation stuff may be show-stopper, but I hope there should be workarounds (cc @Ericson2314)
This mostly moves asserts and throws inside
buildInputsattribute, so we delay evaluation failure to step when derivation is about to evalute.Sorry, I'm not proficient in git, so ignore python-collision related commit. I'll remove it in next PR