Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lumina: 1.3.0 -> 1.4.0-p1 #32013

Merged
merged 1 commit into from Nov 30, 2017
Merged

lumina: 1.3.0 -> 1.4.0-p1 #32013

merged 1 commit into from Nov 30, 2017

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Nov 24, 2017 •
edited

Motivation for this change

Update to version 1.4.0

Release notes

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Nov 25, 2017

Does it also crash on your machine, when you right click on a file in lumina-fm?

This is what gdb says:

(gdb) bt
#0  0x00007f3421c1d010 in QMenu::menuAction() const () from /nix/store/aw8mwr03vcbngdhvf1zb610wl4nwa6c5-qtbase-5.9.1/lib/libQt5Widgets.so.5
#1  0x00007f3421c1dab1 in QMenu::addMenu(QMenu*) () from /nix/store/aw8mwr03vcbngdhvf1zb610wl4nwa6c5-qtbase-5.9.1/lib/libQt5Widgets.so.5
#2  0x000000000048f033 in ?? ()
#3  0x00000000004b0e21 in ?? ()
#4  0x00007f342041517f in QMetaObject::activate(QObject*, int, int, void**) () from /nix/store/aw8mwr03vcbngdhvf1zb610wl4nwa6c5-qtbase-5.9.1/lib/libQt5Core.so.5
#5  0x00007f3421c20f00 in QMenu::popup(QPoint const&, QAction*) () from /nix/store/aw8mwr03vcbngdhvf1zb610wl4nwa6c5-qtbase-5.9.1/lib/libQt5Widgets.so.5
#6  0x0000000000489842 in ?? ()
#7  0x00000000004b0e17 in ?? ()
#8  0x00007f342041517f in QMetaObject::activate(QObject*, int, int, void**) () from /nix/store/aw8mwr03vcbngdhvf1zb610wl4nwa6c5-qtbase-5.9.1/lib/libQt5Core.so.5
#9  0x00000000004b23fd in ?? ()
#10 0x00007f342041517f in QMetaObject::activate(QObject*, int, int, void**) () from /nix/store/aw8mwr03vcbngdhvf1zb610wl4nwa6c5-qtbase-5.9.1/lib/libQt5Core.so.5
#11 0x00007f3421aee195 in QWidget::customContextMenuRequested(QPoint const&) () from /nix/store/aw8mwr03vcbngdhvf1zb610wl4nwa6c5-qtbase-5.9.1/lib/libQt5Widgets.so.5
#12 0x00007f3421b08dcd in QWidget::event(QEvent*) () from /nix/store/aw8mwr03vcbngdhvf1zb610wl4nwa6c5-qtbase-5.9.1/lib/libQt5Widgets.so.5
#13 0x00007f3421be940e in QFrame::event(QEvent*) () from /nix/store/aw8mwr03vcbngdhvf1zb610wl4nwa6c5-qtbase-5.9.1/lib/libQt5Widgets.so.5
#14 0x00007f3421d19183 in QAbstractItemView::viewportEvent(QEvent*) () from /nix/store/aw8mwr03vcbngdhvf1zb610wl4nwa6c5-qtbase-5.9.1/lib/libQt5Widgets.so.5
#15 0x00007f3421d56c5c in QTreeView::viewportEvent(QEvent*) () from /nix/store/aw8mwr03vcbngdhvf1zb610wl4nwa6c5-qtbase-5.9.1/lib/libQt5Widgets.so.5
#16 0x00007f34203ec8d2 in QCoreApplicationPrivate::sendThroughObjectEventFilters(QObject*, QEvent*) () from /nix/store/aw8mwr03vcbngdhvf1zb610wl4nwa6c5-qtbase-5.9.1/lib/libQt5Core.so.5
#17 0x00007f3421ac6e05 in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /nix/store/aw8mwr03vcbngdhvf1zb610wl4nwa6c5-qtbase-5.9.1/lib/libQt5Widgets.so.5
#18 0x00007f3421acf7a0 in QApplication::notify(QObject*, QEvent*) () from /nix/store/aw8mwr03vcbngdhvf1zb610wl4nwa6c5-qtbase-5.9.1/lib/libQt5Widgets.so.5
#19 0x00007f34203ecaea in QCoreApplication::notifyInternal2(QObject*, QEvent*) () from /nix/store/aw8mwr03vcbngdhvf1zb610wl4nwa6c5-qtbase-5.9.1/lib/libQt5Core.so.5
#20 0x00007f3421b21c52 in ?? () from /nix/store/aw8mwr03vcbngdhvf1zb610wl4nwa6c5-qtbase-5.9.1/lib/libQt5Widgets.so.5
#21 0x00007f3421b244e3 in ?? () from /nix/store/aw8mwr03vcbngdhvf1zb610wl4nwa6c5-qtbase-5.9.1/lib/libQt5Widgets.so.5
#22 0x00007f3421ac6e2c in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /nix/store/aw8mwr03vcbngdhvf1zb610wl4nwa6c5-qtbase-5.9.1/lib/libQt5Widgets.so.5
#23 0x00007f3421ace64b in QApplication::notify(QObject*, QEvent*) () from /nix/store/aw8mwr03vcbngdhvf1zb610wl4nwa6c5-qtbase-5.9.1/lib/libQt5Widgets.so.5
#24 0x00007f34203ecaea in QCoreApplication::notifyInternal2(QObject*, QEvent*) () from /nix/store/aw8mwr03vcbngdhvf1zb610wl4nwa6c5-qtbase-5.9.1/lib/libQt5Core.so.5
#25 0x00007f3420ece573 in QGuiApplicationPrivate::processMouseEvent(QWindowSystemInterfacePrivate::MouseEvent*) () from /nix/store/aw8mwr03vcbngdhvf1zb610wl4nwa6c5-qtbase-5.9.1/lib/libQt5Gui.so.5
#26 0x00007f3420ed0145 in QGuiApplicationPrivate::processWindowSystemEvent(QWindowSystemInterfacePrivate::WindowSystemEvent*) () from /nix/store/aw8mwr03vcbngdhvf1zb610wl4nwa6c5-qtbase-5.9.1/lib/libQt5Gui.so.5
#27 0x00007f3420eacebb in QWindowSystemInterface::sendWindowSystemEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /nix/store/aw8mwr03vcbngdhvf1zb610wl4nwa6c5-qtbase-5.9.1/lib/libQt5Gui.so.5
#28 0x00007f340f413210 in ?? () from /nix/store/72h7lrr17bsysw8xg1giazpk142hxpba-qtbase-5.9.1-bin/lib/qt-5.9/plugins/platforms/../../../../../aw8mwr03vcbngdhvf1zb610wl4nwa6c5-qtbase-5.9.1/lib/libQt5XcbQpa.so.5
#29 0x00007f3422467037 in g_main_context_dispatch () from /nix/store/0cgwsihhxi6vzix5vdchrvj8m4qzb3r1-glib-2.54.1/lib/libglib-2.0.so.0
#30 0x00007f34224672a8 in g_main_context_iterate.isra () from /nix/store/0cgwsihhxi6vzix5vdchrvj8m4qzb3r1-glib-2.54.1/lib/libglib-2.0.so.0
#31 0x00007f342246735c in g_main_context_iteration () from /nix/store/0cgwsihhxi6vzix5vdchrvj8m4qzb3r1-glib-2.54.1/lib/libglib-2.0.so.0
#32 0x00007f342043c6df in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /nix/store/aw8mwr03vcbngdhvf1zb610wl4nwa6c5-qtbase-5.9.1/lib/libQt5Core.so.5
#33 0x00007f34203eb82a in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () from /nix/store/aw8mwr03vcbngdhvf1zb610wl4nwa6c5-qtbase-5.9.1/lib/libQt5Core.so.5
#34 0x00007f34203f3f34 in QCoreApplication::exec() () from /nix/store/aw8mwr03vcbngdhvf1zb610wl4nwa6c5-qtbase-5.9.1/lib/libQt5Core.so.5
#35 0x0000000000420188 in main ()

@Mic92
Copy link
Member

Mic92 commented Nov 25, 2017

I also added wrapGAppsHook to nativeBuildInputs as it tries to use gtk icons on my system.

@romildo
Copy link
Contributor Author

romildo commented Nov 30, 2017

Does it also crash on your machine, when you right click on a file in lumina-fm?

Yes. Fortunately this bug has already been fixed in version v1.4.0-p1

@romildo romildo changed the title lumina: 1.3.0 -> 1.4.0 lumina: 1.3.0 -> 1.4.0-p1 Nov 30, 2017
@Mic92 Mic92 merged commit ef89332 into NixOS:master Nov 30, 2017
@romildo romildo deleted the upd.lumina branch December 1, 2017 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@romildo @Mic92 @pSub @GrahamcOfBorg