python-i3ipc: init at 1.3.0 #32030
Closed
python-i3ipc: init at 1.3.0 #32030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRidh
requested changes
Nov 25, 2017
| @@ -0,0 +1,28 @@ | |||
| { pkgs, buildPythonPackage, enum-compat }: | |||
| sha256 = "1rw9mq18np6bf8xp8vvc21bi5q8xjmj8dck2vsa1hy8bk434259m"; | ||
|
|
||
| in buildPythonPackage rec { | ||
| name = "i3ipc-${version}"; |
There was a problem hiding this comment.
pname = "i3ipc";
version = "1.3.0";
no need for name
| fetchSubmodules = true; # because a tag is used | ||
| }; | ||
|
|
||
| doCheck = false; |
There was a problem hiding this comment.
Why? Leave a comment in the code with a reason.
| homepage = "https://github.com/acrisci/i3ipc-python"; | ||
| description = "An improved library to control i3wm"; | ||
| license = pkgs.lib.licenses.bsd3; | ||
| }; |
There was a problem hiding this comment.
are you going to maintain this expression?
There was a problem hiding this comment.
Yes. Added myself as maintainer here and in lib/maintainers.nix
FRidh
reviewed
Dec 8, 2017
| repo = "i3ipc-python"; | ||
| rev = "refs/tags/v${version}"; | ||
| inherit sha256; | ||
| fetchSubmodules = true; # Fetching by tag does not work otherwise |
There was a problem hiding this comment.
seems to fetch just fine here without. Note also that refs/tags can be dropped.
|
(triage) This is now part of If for any reason this needs to be re-opened, re-open, or ask for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The package i3ipc-python is a better-maintained alternative to i3-py which is currently in nixpkgs. Contributors: 26 vs 3. Last commit: 19 days ago vs 6 years ago
Things done