New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auth capability 'login' missing #2173
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain the new flow a bit more? What's the expected behavior after your change?
$form->addElement(form_makeButton('submit', '', $lang['btn_login'])); | ||
$form->endFieldset(); | ||
if(actionOK('login')){ | ||
print tpl_actionlink('login','','','',true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand this change. When the login action is enabled you show a link to the login form otherwise you show the form itself?
@JanWH are you still working on this? |
@splitbrain Sorry for not replying earlier, as I am currently on vacation in this regards a work project of mine. I will get back to you early next week! |
I looked into rewriting and thus replacing this pull request. However, I'm not sure I agree that it is useful/necessary. Plugins can already modify/remove the login form. The oauth plugin is doing exactly that with the HTML_LOGINFORM_OUTPUT event. I'm somewhat confused^^ |
Sorry for the late reply. Thanks @micgro42, I did not discover the I am sorry for wasting everybody's time. 😞 |
In regards to #797, this PR is supposed to add some sort of 'login' capability to an Auth Plugin to allow for custom Login Forms to be presented instead of the default login, that may or may not be used by the plugin.
This is a work in progress. Please don't judge