New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pygobject: 3.24.1 → 3.26.1 #32034
pygobject: 3.24.1 → 3.26.1 #32034
Conversation
I do not like the |
postPatch = '' | ||
# prefix is ${python} by default for some reason | ||
substituteInPlace setup.py --replace '"prefix": self.install_base' "'prefix': '$out'" | ||
''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe the following works
setupPyBuildFlags = [ "--install-base=$out" ];
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does not seem to work – no such option: --install-base
. I also tried
installFlags = [ "--install-base=$out" ];
with the same result, and
installFlags = [ "--install-option=\"--install-base=$out\"" ];
which at least builds but the ${python}
path is still used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The option seems to be distutils-specific, while this package seems to be using setuptools. Edit: It is actually using distutils, no idea why it does not work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently, the problem is caused by pycairo reading an install flag during the build of the wheel. Just like with passing build flags to bdist_wheel, setuptools do not allow passing the install flags either – other than by using hacks like python setup.py install --root=_temp --prefix=/foo bdist_wheel
(source). Let’s keep patching the source for now.
Verified by running |
Motivation for this change
Just an update, trying if it does not fix syncthing-gtk freeze. It does not.
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)