system-config-printer: fix python path #32024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
propagated dependencies were not added to PYTHONPATH
andir
force-pushed
the
unstable-fix-gnome3-printing
branch
from
b69cbfa
to
3f1c436
Compare
|
This was in already, considering If it fixed it indeed, then this needs to be reverted. We really shouldn't use |
|
Original issue: #30596 |
|
I'll try to reproduce and test this again. My test box is currently upgrading to unstable... Will report back once I have results. |
|
You can revert this PR. |
|
Thanks for checking it. I reverted the change on master (f83bb7d). |
FRidh
added a commit
that referenced
this pull request
Nov 26, 2017
…ting" This reverts commit 03207c0, reversing changes made to 822342f. Reverted because the change was not needed anymore: #32024 (comment)
|
Now I'm confused. The patch is reverted on master and not on release-17.09. Is that how it's supposed to be? |
|
Yes, since master already received a fix. On stable I accidentally
introduced `pysmb` while porting the patch. The stable patch minus pysmb is
correct.
…On Nov 26, 2017 11:14 AM, "Bjørn Forsman" ***@***.***> wrote:
Now I'm confused. The patch is reverted on master and not on
release-17.09. Is that how it's supposed to be?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#32024 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAm_dFhw3FWflstejDB3P6iLELk-fFatks5s6Tn9gaJpZM4QqZi->
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
propagated dependencies were not added to PYTHONPATH
Motivation for this change
Installed a vanilla gnome3 with printing enabled. Figured out the printer configuration dialog wasn't working.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)