libertinus: init at 6.4 #31461
Merged
libertinus: init at 6.4 #31461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orivej
suggested changes
Nov 10, 2017
| outputHash = "1fjk3vmixl1gmjn0cj5jyc4r933mqm9wrb6kn447nisxmkvn379j"; | ||
|
|
||
| meta = with stdenv.lib; { | ||
| description = "Libertinus fonts is a fork of the Linux Libertine and Linux Biolinum fonts that started as an OpenType math companion of the Libertine font family, but grown as a full fork to address some of the bugs in the fonts."; |
There was a problem hiding this comment.
The description is too long.
There was a problem hiding this comment.
Is there a rule of thumb for how long descriptions should be?
There was a problem hiding this comment.
It should fit on one line of a full screen terminal (e.g. in the nox output), so the 100 character limit is reasonable, with most descriptions being under 80 characters.
There was a problem hiding this comment.
Thanks for the pointer!
|
|
||
| stdenv.mkDerivation rec { | ||
| name = "libertinus-${rev}"; | ||
| rev = "v6.4"; |
There was a problem hiding this comment.
The version must start with a digit. Use rev = "v${version}" below.
langston-barrett
force-pushed
the
libertinus
branch
from
33428e6
to
3bbcb68
Compare
|
@orivej Thanks for the review! I've made the changes you requested. |
orivej
approved these changes
Nov 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Another nice OTF math font!
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)