Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

neovim: 0.2.0 -> 0.2.1 #31460

Merged
merged 1 commit into from Nov 15, 2017
Merged

neovim: 0.2.0 -> 0.2.1 #31460

merged 1 commit into from Nov 15, 2017

Conversation

garbas
Copy link
Member

@garbas garbas commented Nov 10, 2017 •
edited

  • neovimLibvterm: 5a748f9 -> 4ca7ebf
  • neovim ruby: 0.5.0 -> 0.5.1
  • pythonPackages.neovim: 0.1.13 -> 0.2.0
  • libmpack: 1.0.3-rev80bd55ea6 -> 1.0.5
  • luaPackages.mpack: switched to new source location, 1.0.7_ef025224a7
  • only one set of lua packages, switched to luajit
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@garbas
neovim: 0.2.0 -> 0.2.1
63b7709 
* neovimLibvterm: 5a748f9 -> 4ca7ebf
* neovim ruby: 0.5.0 -> 0.5.1
* pythonPackages.neovim: 0.1.13 -> 0.2.0
* libmpack: 1.0.3-rev80bd55ea6 -> 1.0.5
* luaPackages.mpack: switched to new source location, 1.0.7_ef025224a7
* only one set of lua packages, switched to luajit
@garbas garbas requested a review from FRidh as a code owner November 10, 2017 01:14
@garbas garbas mentioned this pull request Nov 10, 2017
Closed
8 tasks
@teto
Copy link
Member

teto commented Nov 10, 2017 •
edited

I believe lua(jit) should be in propagatedBuildInput (release notes say lua should always be available). I ll try the PR this week end.

@cstrahan
Copy link
Contributor

I believe lua(jit) should be in propagatedBuildInput (release notes say lua should always be available).

propagatedBuildInputs is only responsible for propogating a dependency in another build (e.g. if package A propogates B, then inclusion of A as a build input in package C implies that B will also automagically be one of C's build inputs). As the PR stands, nvim references the luajit store path directly within e.g. rpaths and any other paths referencing luajit resources.

This works as expected: :lua print(1+1)

@teto
Copy link
Member

teto commented Nov 11, 2017

true. It works superbly here !

@Mic92 Mic92 mentioned this pull request Nov 13, 2017
Closed
8 tasks
@garbas garbas merged commit 7dce6c8 into NixOS:master Nov 15, 2017
@garbas garbas deleted the nvim-update branch November 15, 2017 00:21
@edef1c
Copy link
Member

edef1c commented Nov 27, 2017 •
edited

This causes some rather weird terminal behaviour for me: for example, typing :q results in :�[2 qq in my terminal (that's \x1b[2 qq). It turns out that this is caused by libvte not handling unrecognised escape codes properly, but set guicursor= in one's init.vim will disable the neovim feature that causes this issue to surface. This issue has already been fixed in upstream libvte, which I assume means it works fine with gnome3.vte, but our Terminator version still uses gnome2.vte.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@garbas @teto @cstrahan @edef1c @GrahamcOfBorg