Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qt 5.6 fixes #31462

Closed
wants to merge 6 commits into from
Closed

Qt 5.6 fixes #31462

wants to merge 6 commits into from

Conversation

ttuegel
Copy link
Member

@ttuegel ttuegel commented Nov 10, 2017

Motivation

Fix several remaining problems after #31357.

Testing

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@ttuegel ttuegel self-assigned this Nov 10, 2017
@ttuegel ttuegel changed the title Qt 5.6 Qt 5.6 fixes Nov 10, 2017
@orivej orivej mentioned this pull request Nov 10, 2017
Merged
8 tasks
@orivej
Copy link
Contributor

orivej commented Nov 10, 2017 •
edited

Thank you for such a great improvement of the build of Qt and Qt projects!

May we merge this into staging now, or do you have some other plans for this PR?

@ttuegel
Copy link
Member Author

ttuegel commented Nov 11, 2017

I have one more thing to add. Qt 5.6.3 is available; because everything using Qt 5.6 is being rebuilt anyway, I thought I would update it.

@ttuegel
Copy link
Member Author

ttuegel commented Nov 12, 2017

Merged in 605a2c9.

@ttuegel ttuegel closed this Nov 12, 2017
@ttuegel ttuegel deleted the qt-5.6 branch November 12, 2017 15:53
averelld pushed a commit to averelld/nixpkgs that referenced this pull request Nov 20, 2017
nextcloud-client: fix build after qt updates
d84deff 
Probably necessary after restructuring/updates in NixOS#31462
@averelld averelld mentioned this pull request Nov 20, 2017
Closed
8 tasks
bjornfor pushed a commit that referenced this pull request Nov 20, 2017
@bjornfor
nextcloud-client: fix build after qt updates
cce47a6 
Probably necessary after restructuring/updates in #31462
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orivej orivej orivej approved these changes

Assignees

@ttuegel ttuegel

Labels
6.topic: qt/kde 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ttuegel @orivej @GrahamcOfBorg