Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hhvm: fix build with glibc 2.26 #31449

Merged
merged 1 commit into from Nov 9, 2017
Merged

hhvm: fix build with glibc 2.26 #31449

merged 1 commit into from Nov 9, 2017

Conversation

pbogdan
Copy link
Member

@pbogdan pbogdan commented Nov 9, 2017

Motivation for this change

Won't build with glibc 2.26.

/cc maintainer @thoughtpolice

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@vcunat vcunat self-assigned this Nov 9, 2017
@vcunat vcunat merged commit 4173ec1 into NixOS:master Nov 9, 2017
vcunat added a commit that referenced this pull request Nov 9, 2017
@vcunat
Merge #31449: hhvm: fix build with glibc-2.26
fb00ed8
@pbogdan pbogdan deleted the hhvm-glibc-226 branch December 3, 2019 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees

@vcunat vcunat

Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pbogdan @vcunat @GrahamcOfBorg