Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bash-completion: allow lazy loading where possible #31445

Closed
wants to merge 1 commit into from
Closed

bash-completion: allow lazy loading where possible #31445

wants to merge 1 commit into from

Conversation

4z3
Copy link
Contributor

@4z3 4z3 commented Nov 9, 2017 •
edited

Motivation for this change

It is not necessary to source all possible completions found in NIX_PROFILES. As the list found in NIX_PROFILES is a subset of XDG_DATA_DIRS, we can instead rely on bash-completion's lazy
loading facilty.

This change can reduce shell startup time significantly.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@4z3
bash-completion: allow lazy loading where possible
0384ffe 
It is not necessary to source all possible completions found in
NIX_PROFILES.  As the list found in NIX_PROFILES is a subset of
XDG_DATA_DIRS, we can instead rely on bash-completion's lazy
loading facilty[1].

[1]: https://github.com/scop/bash-completion/blob/2.7/bash_completion#L2020-L2022
@dtzWill
Copy link
Member

dtzWill commented Mar 1, 2018

Haven't tried it, but seems like a good idea! Can you update this (resolve the merge conflicts)?

@4z3
Copy link
Contributor Author

4z3 commented Mar 1, 2018

Apparently this was already done in 9988224 🤷‍♂️

@4z3 4z3 closed this Mar 1, 2018
@4z3 4z3 deleted the bash-completion branch March 1, 2018 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: user experience 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@4z3 @dtzWill @c0bw3b @GrahamcOfBorg