Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

usync: init at 0.0.3 #30814

Merged
merged 1 commit into from Nov 14, 2017
Merged

usync: init at 0.0.3 #30814

merged 1 commit into from Nov 14, 2017

Conversation

ebzzry
Copy link

@ebzzry ebzzry commented Oct 26, 2017

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

joachifm
joachifm reviewed Oct 28, 2017
View reviewed changes
pkgs/applications/misc/usync/default.nix Outdated
};

installPhase = ''
mkdir -p $out/bin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or install -m 555 -Dt $out/bin $pname

@ebzzry
Copy link
Author

ebzzry commented Oct 29, 2017

@joachifm fixed

@ebzzry
Copy link
Author

ebzzry commented Nov 14, 2017

Can we have this pulled? 😄

@fpletz fpletz merged commit 5499e42 into NixOS:master Nov 14, 2017
@fpletz
Copy link
Member

fpletz commented Nov 14, 2017

Thanks!

1 similar comment
@ebzzry
Copy link
Author

ebzzry commented Nov 14, 2017

Thanks!

@ebzzry ebzzry deleted the usync-0.0.3 branch November 14, 2017 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joachifm joachifm joachifm left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ebzzry @fpletz @joachifm @GrahamcOfBorg