gradio: init at 6.0.2 #30813
Merged
gradio: init at 6.0.2 #30813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joachifm
requested changes
Oct 28, 2017
lib/maintainers.nix
Outdated
| @@ -548,6 +548,7 @@ | |||
| ryneeverett = "Ryne Everett <ryneeverett@gmail.com>"; | |||
| rzetterberg = "Richard Zetterberg <richard.zetterberg@gmail.com>"; | |||
| s1lvester = "Markus Silvester <s1lvester@bockhacker.me>"; | |||
| samtoday = "Sam Parkinson <sam@sam.today>"; | |||
There was a problem hiding this comment.
Please use your github handle here, it makes it easier to cc you here.
|
|
||
| nativeBuildInputs = [ pkgconfig ]; | ||
| buildInputs = [ | ||
| meson |
There was a problem hiding this comment.
Are meson & ninja used at runtime? If they are build-only then use nativeBuildInputs instead.
| buildInputs = [ | ||
| meson | ||
| ninja | ||
| gcc |
There was a problem hiding this comment.
On linux, gcc will be part of the standard build environment.
samdroid-apps
force-pushed
the
add-gradio
branch
from
8f534ca
to
5ac0106
Compare
|
Thanks for the review @joachifm! I've fixed the name in the maintainers file, and moved the build-only deps into "nativeBuildInputs". |
joachifm
approved these changes
Oct 28, 2017
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Gradio is a very nicely made app for listening to internet radio. This commit makes it easier to install on NixOS.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)