Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsawk: init at 1.5-pre #30810

Merged
merged 1 commit into from Oct 26, 2017
Merged

jsawk: init at 1.5-pre #30810

merged 1 commit into from Oct 26, 2017

Conversation

puffnfresh
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

meta = {
description = "Jsawk is like awk, but for JSON";
homepage = https://github.com/micha/jsawk;
license = "unknown";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find a license specified. What should the value be here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there's no license, it means that by default it should be unfree. But there is, https://github.com/micha/jsawk/blob/5a14c4af3c7b59807701b70a954ecefc6f77e978/jsawk#L11 says "no rights reserved", so I feel like it can be publicDomain? But then, the PKGBUILD says "unknown", and the author accepted it too: micha/jsawk#24, so it's slightly conflicting there. But I still think it's ok to go with publicDomain. Otherwise maybe you'd want to ask upstream for clarification about "no rights reserved" vs "unknown"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vyp I think it's safe to call it public domain based on the "no rights reserved"

Licenses 😿

@grahamc
Copy link
Member

grahamc commented Oct 26, 2017

@GrahamcOfBorg jsawk

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

configuring
no configure script, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/h5918fbj70r34ccbmcd3wjbyshajhsh4-jsawk-1.5-pre
stripping (with flags -S) in /nix/store/h5918fbj70r34ccbmcd3wjbyshajhsh4-jsawk-1.5-pre/bin
patching script interpreter paths in /nix/store/h5918fbj70r34ccbmcd3wjbyshajhsh4-jsawk-1.5-pre
/nix/store/h5918fbj70r34ccbmcd3wjbyshajhsh4-jsawk-1.5-pre/bin/.jsawk-wrapped: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/h404wfcz8rzzlq8vr4z7plcijwzfci72-bash-4.4-p12/bin/bash"
checking for references to /tmp/nix-build-jsawk-1.5-pre.drv-0 in /nix/store/h5918fbj70r34ccbmcd3wjbyshajhsh4-jsawk-1.5-pre...
/nix/store/h5918fbj70r34ccbmcd3wjbyshajhsh4-jsawk-1.5-pre

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/nix/store/h5918fbj70r34ccbmcd3wjbyshajhsh4-jsawk-1.5-pre

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/nix/store/h5918fbj70r34ccbmcd3wjbyshajhsh4-jsawk-1.5-pre

@grahamc
Copy link
Member

grahamc commented Oct 26, 2017

Thank you!

@grahamc grahamc merged commit 0f5eaaf into NixOS:master Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants