uvcdynctrl: init at 0.2 #30806
Merged
uvcdynctrl: init at 0.2 #30806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyp
suggested changes
Oct 26, 2017
| homepage = http://guvcview.sourceforge.net; | ||
| maintainers = [ stdenv.lib.maintainers.puffnfresh ]; | ||
| platforms = stdenv.lib.platforms.linux; | ||
| }; |
There was a problem hiding this comment.
license = stdenv.lib.licenses.gpl3Plus;
| { stdenv, fetchFromGitHub, cmake, pkgconfig, libxml2 }: | ||
|
|
||
| stdenv.mkDerivation rec { | ||
| version = "0.2"; |
There was a problem hiding this comment.
Looks like version for this rev is 0.3.0? https://github.com/cshorler/webcam-tools/blob/bee2ef3c9e350fd859f08cd0e6745871e5f55cb9/uvcdynctrl/CMakeLists.txt#L18
Mic92
reviewed
Oct 26, 2017
| sha256 = "0s15xxgdx8lnka7vi8llbf6b0j4rhbjl6yp0qxaihysf890xj73s"; | ||
| }; | ||
|
|
||
| nativeBuildInputs = [ cmake pkgconfig libxml2 ]; |
There was a problem hiding this comment.
libxml2 is declared a native build input?
$ ldd /nix/store/1xjd4bv819nm40aw9xcg1pdy3yjvnc8w-uvcdynctrl-0.2/bin/uvcdynctrl-0.3.0 | grep xml
libxml2.so.2 => /nix/store/plp8nl7bm74b830q05ncp53x61d7di93-libxml2-2.9.5/lib/libxml2.so.2 (0x00007fc203983000)
puffnfresh
force-pushed
the
package/uvcdynctrl
branch
from
5ebc338
to
6a5074c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)