Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

security.sudo: introduce package option #30815

Closed
wants to merge 1 commit into from
Closed

security.sudo: introduce package option #30815

wants to merge 1 commit into from

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Oct 26, 2017 •
edited

Motivation for this change

This makes it way easier to override the sudo package when using the security.sudo module.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@joachifm
Copy link
Contributor

I'm curious about how this compares to nixpkgs.config.packageOverrides?

@Ma27
Copy link
Member Author

Ma27 commented Nov 2, 2017

In the end you're right, packageOverrides should be used in that case. I've just seen this pattern several times now and thought this would be more convenient, but package overrides means less code to maintain :-)

@Ma27 Ma27 closed this Nov 2, 2017
@Ma27 Ma27 deleted the sudo-package-override branch November 2, 2017 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ma27 @joachifm