luajit: do not override INSTALL_INC #30808
Conversation
Overriding INSTALL_INC caused luajit to be installed directly into the
`include/` directory instead of `include/luajit-${version}` as normally
expected. Previously the path indicated in the pkg-config file also did
not match the actual header file location.
The lua packages that do not currently work with luajit are luaexpat, luazip, cjson and mpack. All the rest work last time I checked. |
|
I only saw a large list of rebuilds and |
|
PSA I'll test this with the rest of the luajit packages hopefully either tomorrow or the day after if no one else does. 👍 |
|
@vyp any news? :-) |
|
@andir Sorry forgot to update, time escaped me actually, been really busy. I don't have time to test this until Sunday unfortunately. Of course, if anyone else wants to test before that, they're free to go ahead and not be dependent on me! (I just thought I could help.) |
|
@thoughtpolice @smironov @vcunat any of you guys (since you are the current maintainers) able to verify this? |
|
You forgot to symlink |
Overriding INSTALL_INC caused luajit to be installed directly into the
include/directory instead ofinclude/luajit-${version}as normallyexpected. Previously the path indicated in the pkg-config file also did
not match the actual header file location.
Since
luajitis expected to work as a drop-in replacement for standard lua the include files ininclude/are retained via symlinks to the sub-directory.Things done
build-use-sandboxinnix.confon non-NixOS)This changes tries to recompile everything that could possible be bundled with
luajit. Many of those packages already failed before this change so I am not able to guarantee that everything does still compile/execute.nix-shell -p nox --run "nox-review wip"./result/bin/)