mpg321: add pkg option to set libao default audio driver #30812
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rycee
reviewed
Oct 26, 2017
| @@ -12,6 +16,8 @@ stdenv.mkDerivation rec { | |||
| hardeningDisable = [ "format" ]; | |||
|
|
|||
| configureFlags = [ | |||
| (stdenv.lib.optional (defaultAudio != null) | |||
| "--with-default-audio=${defaultAudio}") | |||
There was a problem hiding this comment.
The optional function returns a list so I think this actually should be something like
configureFlags = [
("--enable-alsa=" + (if stdenv.isLinux then "yes" else "no"))
] ++ stdenv.lib.optional (defaultAudio != null)
"--with-default-audio=${defaultAudio}";
There was a problem hiding this comment.
Okay, huh, I have no idea how it worked then. It clearly did. Probably something bash interpreted correctly by chance.
There was a problem hiding this comment.
Yes, it correctly sets the configure flag. I changed it to a correct list concatenation anyway.
Tested manually with "alsa" and "pulse" drivers.
Profpatsch
force-pushed
the
mpg321-defaultAudio
branch
from
c934a0e
to
0daf2e2
Compare
|
I guess it works because Rebased to master in 9489348. Many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested manually with "alsa" and "pulse" drivers.
nix-shell -p nox --run "nox-review wip"./result/bin/)