kmplayer: fix desktop file exec #30784

zraexy · 2017-10-25T07:20:28Z

Fix so that kmplayer can be launched via the desktop file

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

peterhoeg · 2017-10-25T08:12:05Z

As this only patches a single line, how about using sed in postPatch like this instead:

postPatch = ''
  sed -i src/kmplayer.desktop \
    -e "s,^Exec.*,Exec=$out/bin/kmplayer -qwindowtitle %c %i %U,"
'';

It's much easier to read if everything needed is directly inside the nix expression.

Note: The sed bit above is untested but should be close to working.

zraexy · 2017-10-25T15:33:48Z

Done and tested.
This should probably be cherry picked to 17.09 since the original update was because it fixed the build.

peterhoeg · 2017-10-25T15:48:50Z

Stable updated in 2120660.

peterhoeg · 2017-10-25T15:48:57Z

Thanks!

kmplayer: fix desktop file exec

9e1ef99

zraexy force-pushed the kmplayer branch from c87fac2 to 9e1ef99 Compare October 25, 2017 15:32

peterhoeg merged commit a47c892 into NixOS:master Oct 25, 2017

zraexy deleted the kmplayer branch October 26, 2017 03:47

Provide feedback