pythonPackages.tensorflow: add flags for efficent math on CPU #30786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRidh
approved these changes
Oct 25, 2017
Mic92
reviewed
Oct 25, 2017
| @@ -7,6 +7,9 @@ | |||
| , cudaSupport ? false, nvidia_x11 ? null, cudatoolkit ? null, cudnn ? null | |||
| # Default from ./configure script | |||
| , cudaCapabilities ? [ "3.5" "5.2" ] | |||
| , sse42Support ? false | |||
| , avx2Support ? false | |||
| , fmaSupport ? false | |||
There was a problem hiding this comment.
What happens if this is enabled, but not supported by the hardware? Would it still works?
|
Most likely it will crash with 'bus error' or somesuch.
Cheers,
JP.
…On Wed, Oct 25, 2017 at 10:10 PM, Jörg Thalheim ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pkgs/development/python-modules/tensorflow/default.nix
<#30786 (comment)>:
> @@ -7,6 +7,9 @@
, cudaSupport ? false, nvidia_x11 ? null, cudatoolkit ? null, cudnn ? null
# Default from ./configure script
, cudaCapabilities ? [ "3.5" "5.2" ]
+, sse42Support ? false
+, avx2Support ? false
+, fmaSupport ? false
What happens if this is enabled, but not supported by the hardware? Would
it still works?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#30786 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABsYziGAzToQkugrpvoHJHRmkPMtb_Uks5sv5WrgaJpZM4QFqAn>
.
|
|
@Mic92 No, it wouldn't -- TensorFlow doesn't support dynamic code paths depending on runtime architecture. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Make tensorflow more efficient on CPU
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)